Implement sparse texture Sample* intrinsics for SPIRV #6377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There seems to be a problem with slang-test when running DX12 compute functional tests with sampler2D - I tested this on a Windows machine with an AMD gpu. The test just fails with error code 1 - is this expected? I have separate the original test into two, one for regular textures and the other for combined texture+sampler resources. Can you run them to confirm that this is also happening in the CI? |
|
need to resolve the conflicts here. |
csyonghe
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4495.
Adds SPIRV support for sparse texture
Sample*intrinsics orSample*with status intrinsics. They are implemented through theSparseResidencycapability.LoadandGatherintrinsic variants are still not implemented for SPIRV and will be addressed in separate PRs.