Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UseGraph::replace #6395

Merged
merged 11 commits into from
Feb 25, 2025
Merged

Fix UseGraph::replace #6395

merged 11 commits into from
Feb 25, 2025

Conversation

saipraveenb25
Copy link
Collaborator

@saipraveenb25 saipraveenb25 commented Feb 19, 2025 •
edited
Loading

  • Remove 'isTrivial' logic and refactored the code so that UseChain does not need to be aware of UseGraph's replacement logic.

Fixes: #6329

@saipraveenb25 saipraveenb25 added the pr: non-breaking PRs without breaking changes label Feb 19, 2025
@saipraveenb25 saipraveenb25 requested a review from a team as a code owner February 19, 2025 00:28
csyonghe
csyonghe previously approved these changes Feb 19, 2025
View reviewed changes
@csyonghe csyonghe merged commit a9f2f8a into shader-slang:master Feb 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe csyonghe approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
2 participants
@saipraveenb25 @csyonghe