Fix zero size array handling in slangc #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shader-slang#2890 1. Fix zero size array handling in slangc 2. Add new zero size array diagnostic test.
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#6399
|
@expipiplus1 @jkwak-work for Cc. |
csyonghe
previously approved these changes
Feb 19, 2025
| @@ -2,12 +2,12 @@ | |||
|
|
|||
| // Test that array size cannot be zero | |||
|
|
|||
| //TEST:SIMPLE: | |||
| //DIAGNOSTIC_TEST:SIMPLE: | |||
There was a problem hiding this comment.
For new tests, we use filecheck instead of a separate expected result file.
Here, you write:
//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK):
There was a problem hiding this comment.
thanks, updated.
| func bar() -> int[0]; |
There was a problem hiding this comment.
Before this line, you can write:
//CHECK: ([[# @LINE+1]]): error 30025
To match for (13): error 30025 in the output.
There was a problem hiding this comment.
thanks, updated.
expipiplus1
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2890