Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradient behavior for min() and max() functions at boundaries. #6411

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix gradient behavior for min() and max() functions at boundaries. #6411

merged 2 commits into from
Feb 21, 2025

Conversation

saipraveenb25
Copy link
Collaborator

@saipraveenb25 saipraveenb25 commented Feb 20, 2025 •
edited
Loading

  • When input values are equal, the gradient is split evenly between both inputs.

Fixes: #6412

@saipraveenb25
Fix gradient behavior for min() and max() functions at boundaries. Wh…
2579fbe 
…en input values are equal, the gradient is split evenly between both inputs.
@saipraveenb25 saipraveenb25 added the pr: non-breaking PRs without breaking changes label Feb 20, 2025
@saipraveenb25 saipraveenb25 self-assigned this Feb 20, 2025
@saipraveenb25 saipraveenb25 requested a review from a team as a code owner February 20, 2025 16:19
@csyonghe csyonghe merged commit ca592d2 into shader-slang:master Feb 21, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe csyonghe approved these changes

Assignees

@saipraveenb25 saipraveenb25

Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradient behavior is inconsistent with torch for max and min functions
2 participants
@saipraveenb25 @csyonghe