Add inner texture type to reflection json #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
previously approved these changes
Feb 21, 2025
|
I don't understand what's going on with the |
csyonghe
previously approved these changes
Feb 25, 2025
|
That should fix the ci result... but now the test fails on my computer. |
csyonghe
approved these changes
Feb 27, 2025
|
what do you mean by "test failed on my computer"? which test is failing? |
|
I think my testing version was wrong, seems to work fine now. Although it looks like something is generally wrong with testing right now since my pr shouldn't be breaking that CI test. |
|
Yeah, that CI failure is irrelevant is already being fixed in top of tree. The PR looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow integer storage textures to be used in playground by letting us infer more formats.