add legalise step for ray payloads #6418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeshavaNV
force-pushed
the
bugfix/gh-5121
branch
from
a090e7b to
4390e2f
Compare
Fixes shader-slang#5121 SPV expects at most one IncomingRayPayloadKHR variable for one entry point - as described by VUID: VUID-StandaloneSpirv-IncomingRayPayloadKHR-04700 However, slang has a bug currently, where if an entry point has more than one out parameter, it generates multiple IncomingRayPayloadKHR variables in the generated SPV. This fails spv validation. This patch adds a new legalize step for all RT shaders that consolidates all out parameters into one block, thereby adhereing to the spv rule
mkeshavaNV
force-pushed
the
bugfix/gh-5121
branch
from
4390e2f to
68e797f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5121
SPV expects at most one IncomingRayPayloadKHR variable for one entry point - as described by VUID: VUID-StandaloneSpirv-IncomingRayPayloadKHR-04700
However, slang has a bug currently, where if an entry point has more than one out parameter, it generates multiple IncomingRayPayloadKHR variables in the generated SPV.
This fails spv validation. This patch adds a new legalize step for all RT shaders that consolidates all out parameters into one block, thereby adhereing to the spv rule