Fix SPIRV error for WorkGraphs #6423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves an error message that is caused while emitting SPIRV code. The cause was on the fact that there is no corresponding IRInst for one of SPIRV instructions when emitting, ``` %in_payload_t = OpTypeNodePayloadArrayAMDX $$T; %in_payload_ptr_t = OpTypePointer NodePayloadAMDX %in_payload_t; ``` There is an IRInst for `OpTypePointer` but there isn't IRInst corresponding to `OpTypeNodePayloadArrayAMDX`. When Slang emits `OpTypePointer` with its second operand `OpTypeNodePayloadArrayAMDX`, it is going to be emitted without a matching IRInst.
|
Closing it because I realized that this is not a good way to solve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves an error message that is caused while emitting SPIRV code.
The cause was on the fact that there is no corresponding IRInst for one of SPIRV instructions when emitting,
There is an IRInst for
OpTypePointerbut there isn't IRInst corresponding toOpTypeNodePayloadArrayAMDX. When Slang emitsOpTypePointerwith its second operandOpTypeNodePayloadArrayAMDX, it is going to be emitted without a matching IRInst.Closes #6391