-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the HLSL supported compiler version to 2018 #6502
Conversation
Fixes #6462 |
3a2be61
to
0cf7420
Compare
0cf7420
to
c70b551
Compare
c70b551
to
d57b580
Compare
Wouldn't this PR conflict with the PR 6445? I am going to submit 6445 this week; if not today. |
Maybe? There was a big discussion about the HLSL version supported in SLANG. csyonghe, do you want to comment on that? |
These are two different things.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Another PR of mine is not going to make it any time soon.
#6445
Set the HLSL-supported compiler version to 2018
Fixes #6462
The compiler is already supporting the new HLSL 2021 features, such as:
Slang is already enforcing ternary operator behavior
Slang supports HLSL 2021 features like select()
However, SLANG does not support templates. So we are rolling back the version to 2018.