Fix codegen bug when targeting PTX with new API #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleino-nv
force-pushed
the
aleino/new-api-invalid-cuda-code-bug
branch
from
8d27bf0 to
e3c1454
Compare
aleino-nv
changed the title
aleino-nv
force-pushed
the
aleino/new-api-invalid-cuda-code-bug
branch
from
8a360de to
216c894
Compare
This just compiles tests/compute/simlpe.slang for PTX with the new compilation API, in order to reproduce a code generation bug.
…wring For shaders like tests/compute/simple.slang, which have a 'numthreads' attribute but no 'shader' attribute, the old compile request API would add an EntryPointAttribute to the AST node of the entry point. However, the new API doesn't, and so a certain ConstRef hack doesn't get applied when using the new API, leading to subsequent code generation issues. This patch also checks for a 'numthreads' attribute when deciding whether to apply the ConstRef hack. This closes issue shader-slang#6507 and helps to resolve issue shader-slang#4760.
Our GitHub runners don't have the CUDA toolkits installed, so they can't run all tests.
aleino-nv
force-pushed
the
aleino/new-api-invalid-cuda-code-bug
branch
from
216c894 to
fb67a82
Compare
cheneym2
reviewed
Mar 4, 2025
There was a problem hiding this comment.
I'm curious. What is the "runner" test list meant for, and why couldn't expected-failure-github.txt be used?
There was a problem hiding this comment.
Our GitHub runners don't have the CUDA toolkits installed, so they can't run all tests.
The unit test I add targets PTX and so needs the CUDA toolkit.
Ideally this should be detected at runtime, but I don't think we can readily do that.
The test should be short-lived, so I just added the runner list as a means to filter.
cheneym2
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #6507 for debugging notes.
This closes issue #6507.