Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tv-casting-app: Fixes for WakeOnLAN #258

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

sharadb-amazon
Copy link
Owner

@sharadb-amazon sharadb-amazon commented May 21, 2024

Change summary

  1. VerifyOrEstablishConnection API in tv-casting-common was connecting to the cachedTargetVideoPlayerInfo object corresponding to the passed in targetVideoPlayerInfo. But it was not copying the value of the isAsleep flag (which is based on whether a player with the same hostname was discovered over DNS-SD or not). This PR makes a change in the CastingServer::VerifyOrEstablishConnection API to copy the isAsleep flag before processing the connection request.
  2. If the WakeONLAN MACAddress CharSpan was empty, the tv-casting-apps were surfacing the TVs as part of discovery results, whereas they should have been surfaced only if we had a valid MACAddress to send the WakeOnLAN packet on (for TVs that support STR). This PR, checks whether the MACAddress is empty in TvCastingApp.java for Android and the data() of the MACAddress Charspan is null for iOS/darwin, before surfacing the player.
  3. This PR reduces the CHIP_DEVICE_CONFIG_STR_WAKE_UP_DELAY_SEC from 10 to 8 seconds so the calling client does not timeout too soon (currently configured at 10 seconds).
  4. Also, this PR calls DeleteAll on the SessionResumptionStorage class when the TV sends the RemoveFabric command, so that the tv-casting-app does NOT resume CASE session with a TV with the old node id.

Testing

Tested with the Android and iOS tv-casting-apps against the Linux tv-app.

Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

@sharadb-amazon sharadb-amazon merged commit 6a954eb into v1.0.0-branch May 24, 2024
5 of 86 checks passed
Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants