Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring towards v2.0 #215

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[WIP] Refactoring towards v2.0 #215

wants to merge 21 commits into from

Conversation

shazow
Copy link
Owner

@shazow shazow commented Sep 1, 2016

Status: Don't use this branch. It's highly experimental and likely broken and might not get merged.

The goal is to clean up and reduce the API surface so that we can introduce many-to-one connections-to-members and persistence without changing too many things across too many layers.

@shazow shazow added this to the v2 milestone Sep 1, 2016
@shazow shazow force-pushed the refactor branch 2 times, most recently from 37a9fea to 3ab50ee Compare September 1, 2016 21:02
@shazow
Copy link
Owner Author

shazow commented Apr 30, 2017

Some notes for myself so I don't forget everything and have to re-figure-everything-out from scratch again next time:

  • Multiplexing connections in the client struct is not the way to go: The room skips sending messages to itself, so the clients are not kept in-sync that way. It would be better to keep separate clients but perhaps share a UserConfig.
  • .. Or maybe it's fine if we do it at the terminal layer.

@rileytg
Copy link

rileytg commented Jun 4, 2017

should i be using this branch for dev? no concrete plans but starting to use ssh-chat more and might wanna hack on it

@shazow
Copy link
Owner Author

shazow commented Jun 5, 2017

@rileytg Hi! Good question. I would suggest working on master. It's not certain that the v2 refactor will get merged anytime soon—I'm experimenting with some big changes which might not pan out.

If you're looking for things to hack on, I suggest checking the Tiny tag which should be just a few lines of changes and a great place to start. For bigger work, Help Wanted is a good one.

@zenware
Copy link

zenware commented Nov 7, 2020

How’s this going?

@shazow
Copy link
Owner Author

shazow commented Nov 7, 2020

@zenware lol

@shazow
Copy link
Owner Author

shazow commented Nov 7, 2020

On a serious note, this branch was a lesson that large refactors are a bad idea as they get increasingly hard to merge and risk of burnout continues to increase with the divergence.

If I ever attempt this again, it will be lots of little breaking changes instead of one giant breaking change.

Someone should write another "semver considered harmful" post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants