Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

オーディオコーデック LYRA のサポートを削除する #499

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Mar 6, 2024

変更履歴

  • [CHANGE] オーディオコーデック LYRA のサポートを削除する

@tnamao tnamao requested review from voluntas and sile March 6, 2024 08:42
@sile
Copy link
Member

sile commented Mar 7, 2024

copilot が生成した要約


This pull request primarily involves the removal of support for the LYRA audio codec across various files. This includes changes in the CHANGES.md file to document this removal, modifications in the examples/check.html file to eliminate references to LYRA, and updates in the packages/sdk/src/base.ts and packages/sdk/src/sora.ts files to remove LYRA related code. Additionally, the @shiguredo/lyra-wasm package has been removed from package.json, and the lyra_worker.ts file has been deleted.

Changes are as follows:

Removal of LYRA support:

Package and file deletions:

packages/sdk/src/base.ts Outdated Show resolved Hide resolved
packages/sdk/src/base.ts Outdated Show resolved Hide resolved
packages/sdk/src/base.ts Outdated Show resolved Hide resolved
Copy link
Member

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつか軽微なコメントはしましたが LGTM です

@tnamao
Copy link
Contributor Author

tnamao commented Mar 7, 2024

@sile 指摘された部分を修正しました。軽くみていただけると助かります

@sile
Copy link
Member

sile commented Mar 7, 2024

対応ありがとうございます。良さそうです 👍

@tnamao
Copy link
Contributor Author

tnamao commented Mar 7, 2024

マージします

@tnamao tnamao merged commit fa443e0 into develop Mar 7, 2024
7 checks passed
@tnamao tnamao deleted the feature/remove-lyra-support branch March 7, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants