Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce precompiled-grammars #880

Merged
merged 21 commits into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ cache
.eslintcache
report-engine-js-compat.json
scripts/compares
tm-grammars-themes
34 changes: 34 additions & 0 deletions bench/bundle-test/bundle.bench.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/* eslint-disable ts/ban-ts-comment */
/* eslint-disable antfu/no-import-dist */

import { bench, describe } from 'vitest'
// @ts-ignore - ignore type error
import { highlight as highlightA } from './dist/index-lite.min.mjs'
// @ts-ignore - ignore type error
import { highlight as highlightB } from './dist/index-wasm.min.mjs'

const code = `
import { ref } from 'vue'

const message = ref('Hello World!')

function reverseMessage() {
// Access/mutate the value of a ref via
// its .value property.
message.value = message.value.split('').reverse().join('')
}

function notify() {
alert('navigation was prevented.')
}
`

describe('bundle', () => {
bench('js-precompiled', async () => {
await highlightA(code)
})

bench('wasm', async () => {
await highlightB(code)
})
})
18 changes: 18 additions & 0 deletions bench/bundle-test/index-lite.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { codeToHtml, createShikiInternal } from '@shikijs/core'
import { createJavaScriptRawEngine } from '@shikijs/engine-javascript/raw'

const shiki = createShikiInternal(
{
langs: [
import('@shikijs/langs-precompiled/ts'),
],
themes: [
import('@shikijs/themes/vitesse-dark'),
],
engine: createJavaScriptRawEngine(),
},
)

export async function highlight(code: string): Promise<string> {
return codeToHtml(await shiki, code, { lang: 'ts', theme: 'vitesse-dark' })
}
18 changes: 18 additions & 0 deletions bench/bundle-test/index-wasm.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { codeToHtml, createShikiInternal } from '@shikijs/core'
import { createWasmOnigEngine } from '@shikijs/engine-oniguruma'

const shiki = createShikiInternal(
{
langs: [
import('@shikijs/langs/ts'),
],
themes: [
import('@shikijs/themes/vitesse-dark'),
],
engine: createWasmOnigEngine(import('@shikijs/engine-oniguruma/wasm-inlined')),
},
)

export async function highlight(code: string): Promise<string> {
return codeToHtml(await shiki, code, { lang: 'ts', theme: 'vitesse-dark' })
}
6 changes: 6 additions & 0 deletions bench/bundle-test/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"private": true,
"scripts": {
"bench:prepare": "rollup -c && du -h dist/*"
}
}
31 changes: 31 additions & 0 deletions bench/bundle-test/rollup.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import resolve from '@rollup/plugin-node-resolve'
import esbuild from 'rollup-plugin-esbuild'

const plugins = [
resolve(),
esbuild({
minify: true,
target: 'esnext',
}),
]

export default [
{
input: 'index-wasm.ts',
output: {
file: 'dist/index-wasm.min.mjs',
format: 'es',
inlineDynamicImports: true,
},
plugins,
},
{
input: 'index-lite.ts',
output: {
file: 'dist/index-lite.min.mjs',
format: 'es',
inlineDynamicImports: true,
},
plugins,
},
]
26 changes: 20 additions & 6 deletions bench/engines.bench.ts → bench/engines/engines.bench.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
/* eslint-disable no-console */
import type { BundledLanguage } from 'shiki'
import type { ReportItem } from '../scripts/report-engine-js-compat'
import type { ReportItem } from '../../scripts/report-engine-js-compat'
import fs from 'node:fs/promises'
import { createHighlighter, createJavaScriptRegexEngine, createOnigurumaEngine } from 'shiki'
import { createJavaScriptRawEngine, createJavaScriptRegexEngine } from '@shikijs/engine-javascript'
import { createHighlighter, createOnigurumaEngine } from 'shiki'
import { bench, describe } from 'vitest'

const js = createJavaScriptRegexEngine()
const jsRaw = createJavaScriptRawEngine()
const wasm = await createOnigurumaEngine(() => import('shiki/wasm'))

const RANGE = [0, 20]

// Run `npx jiti scripts/report-engine-js-compat.ts` to generate the report first
const report = await fs.readFile(new URL('../scripts/report-engine-js-compat.json', import.meta.url), 'utf-8').then(JSON.parse) as ReportItem[]
const report = await fs.readFile(new URL('../../scripts/report-engine-js-compat.json', import.meta.url), 'utf-8').then(JSON.parse) as ReportItem[]
const langs = report.filter(i => i.highlightMatch === true).map(i => i.lang).slice(...RANGE) as BundledLanguage[]
// Clone https://github.com/shikijs/textmate-grammars-themes to `../tm-grammars-themes`
const samples = await Promise.all(langs.map(lang => fs.readFile(`../tm-grammars-themes/samples/${lang}.sample`, 'utf-8')))
const samples = await Promise.all(langs.map(lang => fs.readFile(new URL(`../../tm-grammars-themes/samples/${lang}.sample`, import.meta.url), 'utf-8')))

console.log('Benchmarking engines with', langs.length, 'languages')

Expand All @@ -30,14 +32,26 @@ const shikiWasm = await createHighlighter({
engine: wasm,
})

const shikiJsPrecompiled = await createHighlighter({
langs: await Promise.all(langs.map(lang => import(`@shikijs/langs-precompiled/${lang}`))),
themes: ['vitesse-dark'],
engine: jsRaw,
})

for (const lang of langs) {
describe(lang, () => {
const code = samples[langs.indexOf(lang)]

bench('js', () => {
shikiJs.codeToTokensBase(samples[langs.indexOf(lang)], { lang, theme: 'vitesse-dark' })
shikiJs.codeToTokensBase(code, { lang, theme: 'vitesse-dark' })
})

bench('js-precompiled', () => {
shikiJsPrecompiled.codeToTokensBase(code, { lang, theme: 'vitesse-dark' })
})

bench('wasm', () => {
shikiWasm.codeToTokensBase(samples[langs.indexOf(lang)], { lang, theme: 'vitesse-dark' })
shikiWasm.codeToTokensBase(code, { lang, theme: 'vitesse-dark' })
})
})
}
4 changes: 0 additions & 4 deletions docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,10 @@
},
"devDependencies": {
"@iconify-json/svg-spinners": "catalog:",
"@shikijs/colorized-brackets": "workspace:*",
"@shikijs/transformers": "workspace:*",
"@shikijs/twoslash": "workspace:*",
"@unocss/reset": "catalog:",
"@vueuse/core": "catalog:",
"floating-vue": "catalog:",
"pinia": "catalog:",
"shiki": "workspace:*",
"unocss": "catalog:",
"unplugin-vue-components": "catalog:",
"vitepress": "catalog:",
Expand Down
4 changes: 2 additions & 2 deletions docs/packages/vitepress.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ export default defineConfig({
And then in your [`.vitepress/theme/index.ts`](https://vitepress.dev/guide/custom-theme), install the Vue plugin and import the css with `@shikijs/vitepress-twoslash/styles.css`.

```ts twoslash
import type { EnhanceAppContext } from 'vitepress' // [!code hl]
// @noErrors: true
// .vitepress/theme/index.ts
import type { EnhanceAppContext } from 'vitepress' // [!code hl]
import TwoslashFloatingVue from '@shikijs/vitepress-twoslash/client'
import Theme from 'vitepress/theme'

Expand Down Expand Up @@ -86,7 +86,7 @@ console.log('hello')
// ^?
```

<br> <!-- leaving some space for the query above -->
<div class="h-100" /> <!-- leaving some space for the query above -->

### Vue Single File Component

Expand Down
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"docs": "pnpm -C docs run docs:dev",
"docs:build": "pnpm -C docs run docs:build",
"report-engine-js": "esno scripts/report-engine-js-compat.ts",
"bench": "vitest bench",
"bench": "pnpm -r run bench:prepare && vitest bench",
"prepare": "simple-git-hooks"
},
"devDependencies": {
Expand All @@ -26,12 +26,15 @@
"@rollup/plugin-node-resolve": "catalog:",
"@rollup/plugin-replace": "catalog:",
"@rollup/plugin-terser": "catalog:",
"@shikijs/colorized-brackets": "workspace:*",
"@shikijs/engine-javascript": "workspace:*",
"@shikijs/engine-oniguruma": "workspace:*",
"@shikijs/markdown-it": "workspace:*",
"@shikijs/monaco": "workspace:*",
"@shikijs/rehype": "workspace:*",
"@shikijs/transformers": "workspace:*",
"@shikijs/twoslash": "workspace:*",
"@shikijs/types": "workspace:*",
"@shikijs/vitepress-twoslash": "workspace:*",
"@types/fs-extra": "catalog:",
"@types/hast": "catalog:",
Expand Down Expand Up @@ -62,7 +65,6 @@
"rollup-plugin-copy": "catalog:",
"rollup-plugin-dts": "catalog:",
"rollup-plugin-esbuild": "catalog:",
"rollup-plugin-typescript2": "catalog:",
"shiki": "workspace:*",
"simple-git-hooks": "catalog:",
"taze": "catalog:",
Expand All @@ -76,6 +78,7 @@
"wrangler": "catalog:"
},
"resolutions": {
"@shikijs/colorized-brackets": "workspace:*",
"@shikijs/compat": "workspace:*",
"@shikijs/core": "workspace:*",
"@shikijs/engine-javascript": "workspace:*",
Expand All @@ -84,6 +87,7 @@
"@shikijs/rehype": "workspace:*",
"@shikijs/transformers": "workspace:*",
"@shikijs/twoslash": "workspace:*",
"@shikijs/types": "workspace:*",
"@shikijs/vitepress-twoslash": "workspace:*",
"@types/hast": "catalog:",
"@types/mdast": "catalog:",
Expand Down
3 changes: 3 additions & 0 deletions packages/compat/build.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export default defineBuildConfig({
rollup: {
emitCJS: false,
dts: {
respectExternal: true,
compilerOptions: {
paths: {},
},
Expand All @@ -16,5 +17,7 @@ export default defineBuildConfig({
externals: [
'hast',
'shiki',
'@shikijs/types',
/^@shikijs[\\/].*/,
],
})
4 changes: 4 additions & 0 deletions packages/compat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@
},
"dependencies": {
"@shikijs/core": "workspace:*",
"@shikijs/langs": "workspace:*",
"@shikijs/themes": "workspace:*",
"@shikijs/transformers": "workspace:*",
"@shikijs/types": "workspace:*",
"@shikijs/vscode-textmate": "catalog:",
"shiki": "workspace:*"
},
"devDependencies": {
Expand Down
101 changes: 0 additions & 101 deletions packages/core/rollup.config.mjs

This file was deleted.

2 changes: 2 additions & 0 deletions packages/engine-javascript/build.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { defineBuildConfig } from 'unbuild'
export default defineBuildConfig({
entries: [
'src/index.ts',
'src/engine-compile.ts',
'src/engine-raw.ts',
],
declaration: true,
rollup: {
Expand Down
Loading
Loading