Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine-js): update deps, support more languages #890

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

slevithan
Copy link
Collaborator

@slevithan slevithan commented Jan 14, 2025

Bumps oniguruma-to-es to v2.0.0, which adds comprehensive support for \G.

  • Moves NGINX from Mismatched to Supported.
    • There are no longer any mismatched languages. πŸŽ‰βœ¨ Languages are now either supported or not.
  • Removed option rules.ignoreUnsupportedGAnchors. It no longer exists, because it's no longer useful (all \Gs are supported).
    • Despite the fact that the only remaining sample affected by the incomplete \G support was NGINX, it was a big concern of mine that, until now, ~30% of grammars still had at least one \G that was ignored. In most cases that probably meant there was at least some edge case where the highlighting would be mismatched.
    • Removing this option in this new release is a huge milestone, and means that Shiki's JS engine doesn't need the same level of warnings as before.
  • As a result of the above, I removed more warnings about the JS engine. I've left in place the warning on the compatibility report page that mentions, "In some edge cases, it's not guaranteed that the highlighting will be 100% the same. If that happens, please create an issue with the sample snippet."

Copy link

netlify bot commented Jan 14, 2025

βœ… Deploy Preview for shiki-next ready!

Name Link
πŸ”¨ Latest commit 568c7a7
πŸ” Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/67873f85f83e720008fd6a75
😎 Deploy Preview https://deploy-preview-890--shiki-next.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 14, 2025

βœ… Deploy Preview for shiki-matsu ready!

Name Link
πŸ”¨ Latest commit 568c7a7
πŸ” Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/67873f85ef872200088bbc36
😎 Deploy Preview https://deploy-preview-890--shiki-matsu.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu merged commit d82af15 into shikijs:main Jan 15, 2025
6 of 7 checks passed
@slevithan slevithan deleted the onigtoes2 branch January 15, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants