feat: update for Talos 1.10 current #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle non-signed UKI build, rekres. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
utkuozdemir
approved these changes
Jan 16, 2025
dsseng
approved these changes
Jan 16, 2025
smira
commented
Jan 16, 2025
| @@ -28,8 +28,6 @@ spec: | |||
| customCommands: | |||
| - apk add --no-cache --update | |||
| bash | |||
| binutils-aarch64 | |||
There was a problem hiding this comment.
now we generate UKIs native in Go without objcopy
frezbo
reviewed
Jan 16, 2025
| @@ -28,8 +28,6 @@ spec: | |||
| customCommands: | |||
| - apk add --no-cache --update | |||
| bash | |||
| binutils-aarch64 | |||
There was a problem hiding this comment.
do we need a new errata, but since signed uki's are never reproducable, I guess it doesn't add any value
There was a problem hiding this comment.
hopefully not, they are functionally same (and probably they weren't byte-by-byte same due to external dependency)
frezbo
approved these changes
Jan 16, 2025
DmitriyMV
approved these changes
Jan 16, 2025
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle non-signed UKI build, rekres.