feat: implement SecureBoot asset generation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
frezbo
reviewed
Nov 10, 2023
smira
force-pushed
the
feat/secureboot
branch
from
2263878 to
6a00fd2
Compare
frezbo
reviewed
Nov 13, 2023
| // | ||
| // initramfs/kernel can't carry extra kernel args & META | ||
| // !secureboot (non-UKI) installer can't carry extra kernel args & META | ||
| // UKI installer has kernel args embedded in the UKI image |
There was a problem hiding this comment.
if we want to support, we could later add as efi addons and sd-boot would pick them up
frezbo
approved these changes
Nov 13, 2023
smira
force-pushed
the
feat/secureboot
branch
from
6a00fd2 to
1ea62de
Compare
Fixes siderolabs#19 Using Talos implementation of custom SecureBoot signers, provide full implementation of SecureBoot assets signed either by static local PKI or Azure Key Vault reference. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
feat/secureboot
branch
from
1ea62de to
84113ca
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Using Talos implementation of custom SecureBoot signers, provide full implementation of SecureBoot assets signed either by static local PKI or Azure Key Vault reference.