fix(core/event-list): event list custom height applied for dynamic content #1768

RamVinayMandal · 2025-03-12T11:52:06Z

💡 What is the current behavior?

Custom height in pixels does not apply to dynamically added event list item.

GitHub Issue Number: #1684

🆕 What is the new behavior?

The custom item height (pixels) is applied to the dynamically added event list item.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

🦮 Accessibility (a11y) features were implemented
🗺️ Internationalization (i18n) - no hard coded strings
📲 Responsiveness - components handle viewport changes and content overflow gracefully
📄 Documentation was reviewed/updated (pnpm run docs)
🧪 Unit tests were added/updated and pass (pnpm test)
📸 Visual regression tests were added/updated and pass (Guide)
🧐 Static code analysis passes (pnpm lint)
🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

…ular, React, and Vue test apps.

changeset-bot · 2025-03-12T11:52:10Z

🦋 Changeset detected

Latest commit: 95be052

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@siemens/ix	Patch
@siemens/ix-angular	Patch
@siemens/ix-react	Patch
@siemens/ix-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…custom-height

…eight

packages/core/src/components/event-list/event-list.tsx

nuke-ellington

In general we don't create test app example files for all use cases.
We have unit tests for that.

packages/core/src/components/event-list/event-list.tsx

packages/core/src/components/event-list/test/event-list.ct.ts

…custom-height

…ms, including newly added ones.

…ithub.com:RamVinayMandal/ix into fix-1684/event-list-dynamic-content-custom-height

RamVinayMandal · 2025-03-13T16:33:13Z

In general we don't create test app example files for all use cases. We have unit tests for that.

I added these preview examples to analyze the bug behavior across Angular, React, Vue, and HTML during development. This use case (event-list-custom-item-height-dynamic-list) is different from the existing one (event-list-custom-item-height). Should I remove the new example, or do you think it adds value for debugging and manual verification?

packages/core/src/components/event-list/event-list.tsx

packages/core/src/components/event-list/test/event-list.ct.ts

packages/core/src/components/event-list/event-list.tsx

…vent-list for applying custom height. Updated test case accordingly.

packages/angular-test-app/src/app/app-routing.module.ts

packages/angular-test-app/src/preview-examples/event-list-custom-item-height-dynamic-list.ts

packages/core/src/components/event-list/event-list.tsx

packages/core/src/components/utils/condition-checks.ts

…ved unnecessary code and comments.

…custom-height

…eight

packages/vue-test-app/src/preview-examples/event-list-custom-item-height-in-number.vue

packages/html-test-app/src/preview-examples/event-list-custom-item-height-in-number.html

packages/core/src/components/event-list/event-list.tsx

packages/core/src/components/event-list/test/event-list.ct.ts

…undant event-list-item checks, and optimized test case.

…custom-height

packages/core/src/components/event-list/test/event-list.ct.ts

…custom-height

…om property.

…ithub.com:RamVinayMandal/ix into fix-1684/event-list-dynamic-content-custom-height

packages/core/src/components/event-list/test/event-list.ct.ts

…eight

…he last element before proceeding.

…eight

sonarqubecloud · 2025-04-03T04:23:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

RamVinayMandal added 5 commits March 10, 2025 21:52

Fixed dynamic content height issue and added preview examples for Ang…

9358edd

…ular, React, and Vue test apps.

Added preview example under html-test-app for dynamic content height

38fbb61

HTML content updated

5cb8fe5

Added component test for UI behavior of dynamically added event items.

aeec184

Text formatted using prettier to resolve lint errors

debd26a

Merge branch 'siemens:main' into fix-1684/event-list-dynamic-content-…

a6c2852

…custom-height

danielleroux changed the title ~~Fix(core/event-list): event list custom height applied for dynamic content~~ fix(core/event-list): event list custom height applied for dynamic content Mar 12, 2025

RamVinayMandal added 2 commits March 12, 2025 17:56

Modified test.only with test to pass the test pipeline

051402b

Merge branch 'main' into fix-1684/event-list-dynamic-content-custom-h…

823c1e0

…eight

nuke-ellington reviewed Mar 13, 2025

View reviewed changes

packages/core/src/components/event-list/event-list.tsx Outdated Show resolved Hide resolved

nuke-ellington requested changes Mar 13, 2025

View reviewed changes

packages/core/src/components/event-list/event-list.tsx Outdated Show resolved Hide resolved

packages/core/src/components/event-list/test/event-list.ct.ts Show resolved Hide resolved

RamVinayMandal added 3 commits March 13, 2025 20:32

Merge branch 'siemens:main' into fix-1684/event-list-dynamic-content-…

21b9a7a

…custom-height

Updated test to verify custom height is applied to all event list ite…

a1b760d

…ms, including newly added ones.

Merge branch 'fix-1684/event-list-dynamic-content-custom-height' of g…

2cbdae7

…ithub.com:RamVinayMandal/ix into fix-1684/event-list-dynamic-content-custom-height

nuke-ellington requested changes Mar 13, 2025

View reviewed changes

Enhanced logic to find nested ix-event-list-item elements within ix-e…

26441c1

…vent-list for applying custom height. Updated test case accordingly.

nuke-ellington requested changes Mar 17, 2025

View reviewed changes

RamVinayMandal and others added 4 commits March 18, 2025 18:27

Aligned item height checks, updated number preview examples, and remo…

d3bac5b

…ved unnecessary code and comments.

Merge branch 'siemens:main' into fix-1684/event-list-dynamic-content-…

bbf8402

…custom-height

Removed unnecessary react fragment

33dca96

Merge branch 'main' into fix-1684/event-list-dynamic-content-custom-h…

e713d08

…eight

nuke-ellington requested changes Mar 21, 2025

View reviewed changes

nuke-ellington and others added 3 commits March 21, 2025 10:51

Create tall-walls-vanish.md

83ba9de

Updated Vue and HTML preview examples to use direct tags, removed red…

e73e4ee

…undant event-list-item checks, and optimized test case.

Merge branch 'siemens:main' into fix-1684/event-list-dynamic-content-…

8a96860

…custom-height

nuke-ellington requested changes Mar 26, 2025

View reviewed changes

packages/core/src/components/event-list/test/event-list.ct.ts Outdated Show resolved Hide resolved

RamVinayMandal added 2 commits March 27, 2025 11:29

Merge branch 'siemens:main' into fix-1684/event-list-dynamic-content-…

689f066

…custom-height

Verified computed height instead of checking the presence of the cust…

177060f

…om property.

Merge branch 'fix-1684/event-list-dynamic-content-custom-height' of g…

74b825d

…ithub.com:RamVinayMandal/ix into fix-1684/event-list-dynamic-content-custom-height

nuke-ellington reviewed Mar 28, 2025

View reviewed changes

packages/core/src/components/event-list/test/event-list.ct.ts Outdated Show resolved Hide resolved

RamVinayMandal added 3 commits April 2, 2025 14:01

Merge branch 'main' into fix-1684/event-list-dynamic-content-custom-h…

7b8dc48

…eight

Replaced waitForTimeout with a check to ensure height is applied to t…

a0cca01

…he last element before proceeding.

Merge branch 'main' into fix-1684/event-list-dynamic-content-custom-h…

95be052

…eight

nuke-ellington approved these changes Apr 3, 2025

View reviewed changes

nuke-ellington merged commit 8002d9a into siemens:main Apr 3, 2025
58 of 62 checks passed

This was referenced Apr 3, 2025

Version Packages #1689

Open

Version Packages (alpha) #1816

Merged

danielleroux mentioned this pull request Apr 16, 2025

docs(event-list): add custom item height example #1839

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core/event-list): event list custom height applied for dynamic content #1768

fix(core/event-list): event list custom height applied for dynamic content #1768

RamVinayMandal commented Mar 12, 2025 •

edited

Loading

changeset-bot bot commented Mar 12, 2025 •

edited

Loading

nuke-ellington left a comment

RamVinayMandal commented Mar 13, 2025

sonarqubecloud bot commented Apr 3, 2025

fix(core/event-list): event list custom height applied for dynamic content #1768

fix(core/event-list): event list custom height applied for dynamic content #1768

Conversation

RamVinayMandal commented Mar 12, 2025 • edited Loading

💡 What is the current behavior?

🆕 What is the new behavior?

🏁 Checklist

👨‍💻 Help & support

changeset-bot bot commented Mar 12, 2025 • edited Loading

🦋 Changeset detected

nuke-ellington left a comment

Choose a reason for hiding this comment

RamVinayMandal commented Mar 13, 2025

sonarqubecloud bot commented Apr 3, 2025

Quality Gate passed

RamVinayMandal commented Mar 12, 2025 •

edited

Loading

changeset-bot bot commented Mar 12, 2025 •

edited

Loading