-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orgchart plugin #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some clean up nits
const positionName = config.positionName; //config.positionName; | ||
const area = config.area; //config.area; | ||
const imageUrl = config.imageUrl;// config.imageUrl; | ||
const location = config.location; //config.location; | ||
|
||
//console.log('got data', config, sigmaData, columns, name, id, parentId); | ||
//console.log(config.source); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these comments?
console.log("source", config.source); | ||
console.log("data", sigmaData); | ||
console.log("columns", columns); | ||
/* sigmaData = {} | ||
sigmaData[config.name] = ['sam', 'anand', 'eran', 'darien'] | ||
sigmaData[config.parentId] = ['anand', 'eran', null, 'eran'] | ||
sigmaData[config.id] = ['sam', 'anand', 'eran', 'darien'] | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need the react logos in here
❌ Deploy Preview for sigma-org-chart failed.
|
Port the orgchart pluging for sigma to the sigma repo