Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orgchart plugin #38

Merged
merged 6 commits into from
May 30, 2024
Merged

Add orgchart plugin #38

merged 6 commits into from
May 30, 2024

Conversation

samuel-soubeyran
Copy link
Contributor

@samuel-soubeyran samuel-soubeyran commented Sep 27, 2023

Port the orgchart pluging for sigma to the sigma repo

Copy link

@jsjqian jsjqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some clean up nits

Comment on lines +83 to +89
const positionName = config.positionName; //config.positionName;
const area = config.area; //config.area;
const imageUrl = config.imageUrl;// config.imageUrl;
const location = config.location; //config.location;

//console.log('got data', config, sigmaData, columns, name, id, parentId);
//console.log(config.source);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these comments?

Comment on lines +131 to +138
console.log("source", config.source);
console.log("data", sigmaData);
console.log("columns", columns);
/* sigmaData = {}
sigmaData[config.name] = ['sam', 'anand', 'eran', 'darien']
sigmaData[config.parentId] = ['anand', 'eran', null, 'eran']
sigmaData[config.id] = ['sam', 'anand', 'eran', 'darien']
*/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these?

Copy link

@wtgjxj wtgjxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need the react logos in here

Copy link

netlify bot commented May 30, 2024

Deploy Preview for sigma-org-chart failed.

Name Link
🔨 Latest commit 97a0506
🔍 Latest deploy log https://app.netlify.com/sites/sigma-org-chart/deploys/6658b91e3650b10008c9b05b

@samuel-soubeyran samuel-soubeyran merged commit 03957c3 into main May 30, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants