Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert API token fetch #84

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Revert API token fetch #84

merged 2 commits into from
Nov 26, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 26, 2024

Removed

  • Removed code that calls an endpoint on the management API to get a new token. We observed timing issues related to cookie expiration differences between the static site and the management API. The latter cookie (and session) expiry being extended when accessed, but the static site cookie not being extended, caused an observable discrepancy between static site access level and access level shown on the management page.

@briskt briskt requested a review from a team as a code owner November 26, 2024 03:19
@briskt briskt requested review from jason-jackson and hobbitronics and removed request for a team November 26, 2024 03:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

hobbitronics
hobbitronics approved these changes Nov 26, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@briskt briskt merged commit 4453e2f into main Nov 26, 2024
4 checks passed
@briskt briskt deleted the revert-token-api branch November 26, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics