Skip to content

Commit

Permalink
Restrict selenium to compatible versions
Browse files Browse the repository at this point in the history
These are only used by the test suite. But this probably means we won't
be able to support ruby <3.0 for much longer. (2.6 and 2.7 are EOL,
though, so that seems reasonable.)
  • Loading branch information
sj26 committed Aug 6, 2023
1 parent 4674d89 commit 90e31e1
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ gemspec
# mime-types 3+, required by mail, requires ruby 2.0+
gem "mime-types", "< 3" if RUBY_VERSION < "2"

if RUBY_VERSION < "2.7"
# Ruby 2.7 requirement introduced
# https://github.com/SeleniumHQ/selenium/blob/selenium-4.2.0/rb/CHANGES#L25
gem "selenium-webdriver", "< 4.2.0", group: :development
elsif RUBY_VERSION < "2.8"
# Ruby 3.0 requirement introduced
# https://github.com/SeleniumHQ/selenium/blob/selenium-4.9.1/rb/CHANGES#L5
gem "selenium-webdriver", "< 4.9.1", group: :development
end

#group :development do
# gem "pry"
#end

0 comments on commit 90e31e1

Please sign in to comment.