Fixed transaction signatures order. #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Kielar <zorba128@interia.pl>
Signed-off-by: Marcin Kielar <zorba128@interia.pl>
….serialize` is called without preceding it with `Transaction.sign`. Signed-off-by: Marcin Kielar <zorba128@interia.pl>
|
Also updated Transaction/TransactionBuilder signature handling to ensure correct signature order. This should make it possible to correctly sign non-trivial transactions that involve multiple instructions/accounts. |
zorba128
changed the title
Message to support external signers
|
Any chance? Or maybe discussion? This is really broken, with transaction that requires few signatures it is impossible now to guess what to pass to sign method... Just try to make transaction with memo and few different token transfers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved
Messageto support external signers.Also some refactorings be able to use it outside of Transaction/TransactionBuilder.