Fix PreviewPublicDetector #206
Conversation
Resolves #189
| @@ -30,6 +31,7 @@ class PreviewPublicDetectorTest : BaseSlackLintTest() { | |||
| lint().files(kotlin(code)).allowCompilationErrors().run().expectClean() | |||
| } | |||
|
|
|||
| @Ignore("TODO code review") | |||
There was a problem hiding this comment.
@mrmans0n @chrisbanes I was surprised to find this test that starts failing after the fix. The test seems to disagree with the check's stated purpose, do you have more details?
There was a problem hiding this comment.
Not sure. I assume the second function declaration is a typo
There was a problem hiding this comment.
Tried to remember why this was done... but I can't recall exactly. The idea I think was around previews being alright being public, private or whatever unless they had an annotated param for stub preview data (which made them stupid to be public then). But the meaning of the rule changed over time (adding a param to control this was added, many behavior changes happened later).
In the end I simplified it to just check for public + preview, and ignore everything else in my repo https://github.com/mrmans0n/compose-rules/blob/main/rules/common/src/main/kotlin/io/nlopez/compose/rules/PreviewPublic.kt
You could do the same and call it a day.
Resolves #189