-
Notifications
You must be signed in to change notification settings - Fork 78
ENH: Add PyDMWindow widget to configure hiding the nav bar, menu bar, and status bar components on first load #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this is cool! especially with the potential to expand with more properties
also i think it would be helpful to add to /examples
a simple .ui file that showcases using PyDMWindow as a base.
and could we add an .rst file for PyDMWindow to the docs?
its nice to have doc pages for the widgets have some explanation about it above the api documentation, like https://slaclab.github.io/pydm/widgets/tab_widget.html, but most lack it atm.
865873d
to
5871a80
Compare
Done
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried building docs (https://github.com/slaclab/pydm?tab=readme-ov-file#building-the-documentation-locally), and getting some warnings that we should address.
also getting error when trying to load example
5871a80
to
a1949b2
Compare
Hopefully resolved docs errors. I'm not sure why opening the example is giving you errors, it works on my machine |
ok nice, example works for me now! sry prob was just something odd on my end. also optional to add if u want, WARNING: autodoc: failed to import class 'channel.PyDMChannel' from module 'pydm'; the following exception was raised: we could include the fix in the patch so building is entirely clean _--- a/docs/source/channel.rst -.. autoclass:: channel.PyDMChannel |
…ow it to hide certain window components on first load
ef78c4a
to
016671d
Compare
Done, and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Command-line parameters exist to hide these components on startup, however these aren't possible to set in Qt Designer. This PR adds the
PyDMWindow
widget which can replaceQWidget
as the root of a display widget hierarchy, and it exposes the options to hide these components on first load as checkboxes in the properties section in Designer. When a display using this widget is loaded, it will apply the requested settings if it is the first display loaded in that instance of PyDM, similar to how the command-line parameters work.Closes #1113