Skip to content

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 28, 2025

Reverts #2036

Doesn't fully work:

9:45AM INF Registering and fetching protos from 1 repositories
9:45AM WRN GITHUB_TOKEN is not set, using unauthenticated GitHub client. This may cause rate limiting issues when downloading proto files
9:45AM INF Registering 12 protobuf schemas
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/user_logs.proto not found in protoMap
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/workflow_status_changed.proto not found in protoMap
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/capability_finished.proto not found in protoMap
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/capability_started.proto not found in protoMap
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/metering.proto not found in protoMap
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/workflow_finished.proto not found in protoMap
9:45AM WRN Import workflows/v1/metadata.proto in workflows/workflows/v1/workflow_started.proto not found in protoMap
9:45AM INF ✔ Registered: workflows/common/v1/base_message.proto as cre-common.v1.BaseMessage

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve the configuration and error handling for fetching and registering protobuf schemas from GitHub repositories. They simplify the process by removing unnecessary configurations and enhancing the logging mechanism to give more detailed feedback during the process.

What

  • framework/components/dockercompose/chip_ingress_set/protos.go
    • Removed ExcludeFiles field from ProtoSchemaSet struct to simplify configuration.
    • Added detailed debug logging to enhance visibility during proto fetching and registration processes.
    • Simplified GitHub token check and client creation logic to make it more readable.
    • Removed exclusion logic for files during proto fetching to simplify the process.
    • Improved error messages and added debug logs for better troubleshooting.
    • Changed the registration function name to registerAllWithTopologicalSortingByTrial and updated its logic to try registering protos in different orders if necessary, improving robustness.
    • Streamlined the proto fetching function to enhance clarity and maintainability.
    • Removed unused code related to dependency graph building and topological sorting, simplifying the registration process.
    • Updated comments and logging messages to reflect the simplified approach to proto registration.

@Tofel Tofel marked this pull request as ready for review August 28, 2025 09:55
@Tofel Tofel requested a review from a team as a code owner August 28, 2025 09:55
@Tofel Tofel enabled auto-merge (squash) August 28, 2025 09:56
@Tofel Tofel merged commit a8cb085 into main Aug 28, 2025
70 checks passed
@Tofel Tofel deleted the revert-2036-chore/exclude-files branch August 28, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants