Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Audit on Checkin/out #16679

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Apr 9, 2025

Adding in an option to log an audit when you check in or out an asset.
Screenshot 2025-04-09 at 7 29 22 PM

Screenshot 2025-04-09 at 7 30 02 PM

There is less information on the audit itself, but all changes to an asset will be logged on the checkin or out.

NOTE: This action does not allow a user to manually set a next audit date OR upload a picture as these are not options on checkin or checkout

Copy link

what-the-diff bot commented Apr 9, 2025

PR Summary

  • Improvement in Asset Tracking
    The system now records all instances where assets are either checked in or out. This enhanced tracking feature includes new mechanisms for verifying user permissions and keeping track of these actions in AssetCheckinController and AssetCheckoutController.

  • Enhanced User Interface Language
    New entries have been introduced to the language files to support the newly introduced audit feature. This includes new text for checkboxes and additional help text to guide users through the process.

  • Check-In View Modification
    The check-in form now features a checkbox that allows enabling or disabling the audit log. Its display is subject to the respective user's permissions.

  • Check-Out View Modification
    Much like the check-in view, the check-out form also features a checkbox that governs the audit log. It too is displayed depending on the permissions granted to the user.

@@ -71,6 +71,10 @@ public function store(AssetCheckoutRequest $request, $assetId) : RedirectRespons

$admin = auth()->user();

if($request->filled('audit_on_checkinout') == "1") {
$this->authorize('audit', Asset::class);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably result in a forbidden error, which is probably not what we want. We probably want to quietly ignore if they don't have permission to audit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay yea. i see how that could happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants