Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16689: re-add note field in API files listing for AssetModel #16694

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

r-xyz
Copy link
Contributor

@r-xyz r-xyz commented Apr 12, 2025

Fixes #16689 reintroducing note field in API files listing for AssetModel.

Also improved the tests, to avoid removal by accident in the future.

@r-xyz r-xyz requested a review from snipe as a code owner April 12, 2025 22:39
Copy link

what-the-diff bot commented Apr 12, 2025

PR Summary

  • Enhancement of Asset Transformation Method
    The transformAssetModelFile method in the file AssetModelsTransformer.php was modified. This modification now includes a note in the transformed result, enhancing the comprehensive details provided in each asset transformation.

  • Update of Test File
    The AssetModelFilesTest.php testing file has been updated. This update not only includes additional tests to confirm proper upload of files annotated with notes, but also improves the assertions to efficiently check the JSON structure. There is also a specific validation process for the note field linked to uploaded files, ensuring its accurate handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant