Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1926267: Fix promise rejecting for file upload errors #1008

Merged
merged 8 commits into from
Mar 10, 2025
Merged

SNOW-1926267: Fix promise rejecting for file upload errors #1008

merged 8 commits into from
Mar 10, 2025

Conversation

sfc-gh-dheyman
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner February 13, 2025 15:43
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team February 28, 2025 06:18
@sfc-gh-ajjoshi
Copy link

sfc-gh-ajjoshi commented Mar 4, 2025 •
edited
Loading

Can we please make sure this is merged with priority? @sfc-gh-dheyman

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1926267-put-errors-raise-fix branch from ad6e136 to 4bacd88 Compare March 4, 2025 11:21
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1926267-put-errors-raise-fix branch 2 times, most recently from e4effe7 to ec8b5bd Compare March 5, 2025 09:12
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1926267-put-errors-raise-fix branch from ec8b5bd to 43dab5a Compare March 10, 2025 14:01
sfc-gh-astachowski
sfc-gh-astachowski approved these changes Mar 10, 2025
View reviewed changes
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit b03ddf7 into master Mar 10, 2025
42 of 45 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1926267-put-errors-raise-fix branch March 10, 2025 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik left review comments

@PoornakumarRasiraju PoornakumarRasiraju PoornakumarRasiraju approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sfc-gh-dheyman @sfc-gh-ajjoshi @PoornakumarRasiraju @sfc-gh-dprzybysz @sfc-gh-pmotacki @sfc-gh-astachowski @sfc-gh-mkubik