Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1313628: NodeJS - Verify value bindings for all field types while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD #1013

Closed
wants to merge 58 commits into from

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Feb 18, 2025

Description

Please explain the changes you made here.

  • Add testing to validate whether stage and array binding have the same values.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner February 18, 2025 19:59
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1313628 SNOW-1313628: NodeJS - Verify value bindings for all field types while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD Feb 18, 2025
sfc-gh-pmotacki and others added 21 commits March 4, 2025 10:24
… apply separate settings for separate destinations (#946)

Co-authored-by: Przemyslaw Motacki <przemyslaw.motacki@snowflake.com>
Co-authored-by: Gabe Gorelick <gabe@hightouch.io>
…default doesn't log non-enumerable properties, thus in Error: none) (#944)
sfc-gh-fpawlowski and others added 23 commits March 4, 2025 10:28
… send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar (GCP) (#982)
Co-authored-by: Dawid Heyman <dawid.heyman@snowflake.com>
…ports Snowflake VS Code Extension SSO (#1003)

Co-authored-by: Kelly Huntlin <kelly.huntlin@gmail.com>

The VS Code extension for Snowflake has had this patched for 1.5 years to make single sign-on via SAML work for all customers (non-remote dev).

Without it, there are SSO problems when customers login, since the VS Code API has an API to openExternal: https://code.visualstudio.com/api/references/vscode-api (search for openExternal) that controls how browser windows open from extensions.

We are finally adding this in so we don't have to patch anymore.
Copy link

github-actions bot commented Mar 4, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


12 out of 13 committers have signed the CLA.
✅ (sfc-gh-pmotacki)[https://github.com/sfc-gh-pmotacki]
✅ (ZeRego)[https://github.com/ZeRego]
✅ (ovr)[https://github.com/ovr]
✅ (sfc-gh-ext-simba-jy)[https://github.com/sfc-gh-ext-simba-jy]
✅ (felipecsl)[https://github.com/felipecsl]
✅ (sfc-gh-akolodziejczyk)[https://github.com/sfc-gh-akolodziejczyk]
✅ (sfc-gh-dszmolka)[https://github.com/sfc-gh-dszmolka]
✅ (sfc-gh-dprzybysz)[https://github.com/sfc-gh-dprzybysz]
✅ (sfc-gh-dheyman)[https://github.com/sfc-gh-dheyman]
✅ (sfc-gh-fpawlowski)[https://github.com/sfc-gh-fpawlowski]
✅ (hd-o)[https://github.com/hd-o]
✅ (sfc-gh-klin)[https://github.com/sfc-gh-klin]
@sfc-gh-snowflakedb-snyk-sa
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-ext-simba-jy
Copy link
Collaborator Author

Move this PR to #1020

@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.