SNOW-1944643 - network error retries

lib/connection/statement.js

@@ -1486,9 +1486,7 @@ function sendSfRequest(statementContext, options, appendQueryParamOnRetry) {
     // if we haven't exceeded the maximum number of retries yet and the server
     // came back with a retryable error code
     if (numRetries < maxNumRetries &&
-      err && (Util.isRetryableHttpError(
-        err.response, false // no retry for HTTP 403
-      ) || Util.isNetworkError(err))
+      err && (Util.isRetryableHttpError(err.response, false) || Util.isNetworkError(err))
     ) {
       // increment the retry count
       numRetries++;

lib/util.js

@@ -469,7 +469,7 @@ exports.isRetryableHttpError = function (response, retry403) {
 };
 
 exports.isNetworkError = function (err) {
-  return err.code === Errors.codes.ERR_SF_NETWORK_COULD_NOT_CONNECT
+  return err.code === Errors.codes.ERR_SF_NETWORK_COULD_NOT_CONNECT;
 };
 
 exports.validateClientSessionKeepAliveHeartbeatFrequency = function (input, masterValidity) {

test/authentication/connectionParameters.js

@@ -80,13 +80,13 @@ const keypairEncryptedPrivateKeyPath =
 
 const wiremock =
   {
-        ...baseParameters,
-        accessUrl: null,
-        username: 'MOCK_USERNAME',
-        account: 'MOCK_ACCOUNT_NAME',
-        host: 'localhost',
-        protocol: 'http',
-        authenticator: 'OAUTH',
+    ...baseParameters,
+    accessUrl: null,
+    username: 'MOCK_USERNAME',
+    account: 'MOCK_ACCOUNT_NAME',
+    host: 'localhost',
+    protocol: 'http',
+    authenticator: 'OAUTH',
   };
 
 exports.externalBrowser = externalBrowser;

test/integration/testConnectionRetries.js

@@ -2,8 +2,6 @@
  * Copyright (c) 2015-2024 Snowflake Computing Inc. All rights reserved.
  */
 
-const snowflake = require('./../../lib/snowflake');
-const { v4: uuidv4 } = require('uuid');
 const { runWireMockAsync, addWireMockMappingsFromFile  } = require('../wiremockRunner');
 const connParameters = require('../authentication/connectionParameters');
 const AuthTest = require('../authentication/authTestsBaseClass');
@@ -16,11 +14,6 @@ describe('Connection test', function () {
 
   this.timeout(180000);
 
-  snowflake.configure({
-    logLevel: "DEBUG",
-    disableOCSPChecks: true
-  });
-
   before(async () => {
     port = await testUtil.getFreePort();
     wireMock = await runWireMockAsync(port);

test/integration/testUtil.js

@@ -400,4 +400,4 @@ module.exports.getFreePort = async function () {
       srv.close(() => res(port));
     });
   });
-}
+};

test/integration/wiremock/testWiremockRunner.js

@@ -1,6 +1,5 @@
 const assert = require('assert');
 const fs = require('fs');
-const net = require('net');
 const axios = require('axios');
 const { runWireMockAsync } = require('../../wiremockRunner');
 const os = require('os');