Skip to content

chore: added ignore wf cmd #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

chore: added ignore wf cmd #5849

merged 1 commit into from
Apr 24, 2025

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Apr 23, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

@ShawkyZ ShawkyZ requested a review from a team as a code owner April 23, 2025 12:27
@ShawkyZ ShawkyZ enabled auto-merge April 23, 2025 13:20
@PeterSchafer
Copy link
Collaborator

@ShawkyZ can you add some User Journey tests please?

@ShawkyZ
Copy link
Contributor Author

ShawkyZ commented Apr 23, 2025

@ShawkyZ can you add some User Journey tests please?

@CatalinSnyk @j-luong if you can please add the user journey tests to the CLI. Unfortunately I won't have the capacity to do it and we need this change in LS.

@ShawkyZ
Copy link
Contributor Author

ShawkyZ commented Apr 23, 2025

fyi @PeterSchafer the commit will be prefixed with "feat" if that's ok with you

@ShawkyZ ShawkyZ force-pushed the feat/ignore-wf-cmd branch 2 times, most recently from f8fe637 to 7794246 Compare April 23, 2025 20:52
@ShawkyZ ShawkyZ force-pushed the feat/ignore-wf-cmd branch from 7794246 to 11e6e0e Compare April 24, 2025 13:09
@ShawkyZ ShawkyZ enabled auto-merge April 24, 2025 13:09
@PeterSchafer
Copy link
Collaborator

PeterSchafer commented Apr 24, 2025

fyi @PeterSchafer the commit will be prefixed with "feat" if that's ok with you

I think it should be chore for now. But probably okay to leave it and we can remove it from the release notes later.

@ShawkyZ ShawkyZ force-pushed the feat/ignore-wf-cmd branch from 11e6e0e to 86a4d21 Compare April 24, 2025 16:24
@ShawkyZ ShawkyZ changed the title feat: added ignore wf cmd chore: added ignore wf cmd Apr 24, 2025
@ShawkyZ ShawkyZ disabled auto-merge April 24, 2025 16:28
@ShawkyZ ShawkyZ enabled auto-merge April 24, 2025 16:28
@ShawkyZ ShawkyZ merged commit d07fa7e into main Apr 24, 2025
8 checks passed
@ShawkyZ ShawkyZ deleted the feat/ignore-wf-cmd branch April 24, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants