-
Notifications
You must be signed in to change notification settings - Fork 711
[show][config][plugin] add processing of ModuleNotFoundError with log_warning #3832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maksym-kovalchuk
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
maksym-kovalchuk:plugin-not-found-error-processing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[show][config][plugin] add processing of ModuleNotFoundError with log_warning #3832
maksym-kovalchuk
wants to merge
2
commits into
sonic-net:master
from
maksym-kovalchuk:plugin-not-found-error-processing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
approved these changes
Apr 7, 2025
6b5b3a3
to
a401ddc
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
a401ddc
to
726b3f7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
726b3f7
to
b341e11
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
b341e11
to
99d5e4b
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
99d5e4b
to
da71522
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
da71522
to
cedd723
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
cedd723
to
4e1db14
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4e1db14
to
05b8ffe
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…ning log message instead of default error message Avoid excess error messages for cases of race conditions when plugin was removed right before the stage of its loading Signed-off-by: Maksym Kovalchuk <mkovalchuk@nvidia.com>
Signed-off-by: Maksym Kovalchuk <mkovalchuk@nvidia.com>
05b8ffe
to
1793c04
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the case of rare situation of race condition when plugin script file is removed right before the stage of its load via cli (e.g. in case of dynamic removing with app extensions). This situation has no impact but generate additional error messages to syslog
What I did
Add separate processing ModuleNotFoundError with log_warning messages to avoid excess ERR printing
How to verify it
It happens very rarely in nature but you can just try to remove plugin script manually right before its loading stage. I used this changes on top of my commit for testing: