[202411] Stop the hwclock service and timer files before updating CMOS time #3853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rebooting or doing a warm/fast reboot, stop the hwclock service and timer files before running `hwclock -w`. This removes the chance of a race condition where both of them run at the same time, causing one of them to fail. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Apr 24, 2025
|
@saiarcot895 why do we not need this fix in master branch? |
|
@yxieca This change (of having the hwclock service and timer files) is not present in the master branch because Chrony is handling the RTC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When rebooting or doing a warm/fast reboot, stop the hwclock service and timer files before running
hwclock -w. This removes the chance of a race condition where both of them run at the same time, causing one of them to fail.Fixes sonic-net/sonic-buildimage#22230
How I did it
How to verify it
This is a race condition, and as such, may require a couple hundred reboot attempts to occur. With the fix, it's expected that this race condition will not occur at all.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)