Further favorite item/weapon functionality and fixes #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolve issue where we were storing favorites in the incorrect format, resulting in a client error on game load - Resolve issue where we were clearing favorites when they were meant to be saved - On login, fix any previously corrupted favorites array - Properly implement favorite data in `getOtherProfile`, now shows your favorites when viewing your profile
|
I think this should technically target a 3.10.2 branch, but that doesn't exist yet. Let me know if you would like me to re-target the PR tomorrow This resolves #960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getOtherProfile, now shows your favorites when viewing your profile