fix(permission): Check is_school_admin not has_group_by_id

apps/core/models/signals/comment.py

@@ -33,9 +33,7 @@ def update_communication_article_status(comment):
         )
         if (
             article.parent_board.is_school_communication
-            and comment.created_by.profile.has_group_by_id(
-                7
-            )  # 7 = Communication board admin
+            and comment.created_by.profile.is_school_admin
             and article.communication_article.school_response_status
             != SchoolResponseStatus.ANSWER_DONE
         ):

apps/core/permissions/communication_article.py

@@ -7,6 +7,4 @@ class CommunicationArticleAdminPermission(permissions.IsAuthenticated):
     message = "You are not authorized to access this feature"
 
     def has_permission(self, request, view):
-        return request.user.is_staff or request.user.profile.has_group_by_id(
-            7
-        )  # 7 = Communication board admin
+        return request.user.is_staff or request.user.profile.is_school_admin

apps/core/views/viewsets/comment.py

@@ -84,12 +84,10 @@ def perform_create(self, serializer):
             )
             parent_article = parent_comment.parent_article
 
-        print(parent_article)
+        # print(parent_article)
 
         created_by = self.request.user
-        is_school_admin = UserProfile.objects.get(user_id=created_by).has_group_by_id(
-            7
-        )  # 7 = Communication board admin
+        is_school_admin = UserProfile.objects.get(user_id=created_by).is_school_admin
 
         if is_school_admin and parent_article.name_type != NameType.ANONYMOUS:
             name_type = NameType.REGULAR