Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#450 택시비용 보여주기 #451

Merged
merged 45 commits into from
Jul 24, 2024
Merged

#450 택시비용 보여주기 #451

merged 45 commits into from
Jul 24, 2024

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Feb 6, 2024 •
edited
Loading

Summary

It closes #450

taxi-back 분들이 스타일이랑 코드 위치, 그리고 코드를 바꿔주시면 감사하겠습니다 😆
issue 페이지에 상세히 적어놓았습니다.

Further Work

  • 작은 자원으로 진행할 수 있는 대안 db가 있다면, 해당 사항으로 넘어가야합니다.
  • taxi-front에서 해당 정보를 보여주는 컴포넌트를 작성해야 합니다.
  • Naver API 스팍스 계정으로 발급해서 환경변수를 등록해야 합니다.
  • 장소도 지금은 location.json을 그냥 따로 만들어 놓았는데, 회의 끝나고 기존 taxi-back의 정보로 처리하는 방향으로 처리하겠습니다.
  • validator를 지금 연결 안 해 놓았네요 ;; 바로 해놓겠습니다

@ybmin ybmin added the ⚒ enhancement New feature or request label Feb 6, 2024
@ybmin ybmin self-assigned this Feb 6, 2024
@ybmin ybmin marked this pull request as draft February 6, 2024 14:52
@ybmin ybmin added the 🖥 working 아직 작업 중인 상태 label Feb 6, 2024
@ybmin
Copy link
Contributor Author

ybmin commented Mar 9, 2024

24h를 30분 단위로 분리 & 요일 정보도 하나로 관리, 0 ~ 6 (Sunday~Saturday) * 48 + 0 ~ 47 (0:00 ~ 23:30)

kmc7468
kmc7468 reviewed Mar 12, 2024
View reviewed changes
src/routes/fare.js Outdated Show resolved Hide resolved
xMHW
xMHW reviewed Mar 12, 2024
View reviewed changes
src/services/fare.js Outdated Show resolved Hide resolved
chlehdwon
chlehdwon reviewed Mar 12, 2024
View reviewed changes
src/services/fare.js Outdated Show resolved Hide resolved
src/services/fare.js Outdated Show resolved Hide resolved
@ybmin ybmin marked this pull request as ready for review March 26, 2024 13:26
@ybmin ybmin requested review from kmc7468 and chlehdwon May 7, 2024 11:49
chlehdwon
chlehdwon requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@chlehdwon chlehdwon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네이버 지도 API ID/KEY 값은 공유되는 건가요? 다음에 공유해주시면 감사하겠습니다~!
문서화 부분은 제가 수정해서 commit 올려 놓을게요

src/modules/fare.js Outdated Show resolved Hide resolved
@ybmin
Copy link
Contributor Author

ybmin commented Jul 9, 2024

https://github.com/sparcs-kaist/taxi-back/pull/430 가 머지된 후에 붙입니다.

@ybmin ybmin marked this pull request as draft July 17, 2024 07:52
@ybmin ybmin marked this pull request as ready for review July 18, 2024 10:34
@ybmin ybmin marked this pull request as draft July 18, 2024 10:37
@ybmin ybmin marked this pull request as ready for review July 18, 2024 13:06
kmc7468
kmc7468 requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자꾸 요청사항 드려서 죄송합니다...ㅠㅠ

src/modules/fare.js Outdated Show resolved Hide resolved
loadenv.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/modules/fare.js Outdated Show resolved Hide resolved
src/modules/stores/mongo.js Outdated Show resolved Hide resolved
src/modules/fare.js Outdated Show resolved Hide resolved
src/modules/fare.js Outdated Show resolved Hide resolved
src/modules/fare.js Outdated Show resolved Hide resolved
src/services/fare.js Outdated Show resolved Hide resolved
src/services/fare.js Outdated Show resolved Hide resolved
kmc7468
kmc7468 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 저의 수많은 요청 사항 받아주시느라 고생 많으셨습니다~~

진짜 마지막 요청 사항만 반영 부탁드려요!! (제가 커밋 하나 해가지구 수정 전 git pull 필요합니다)

src/routes/fare.js Outdated Show resolved Hide resolved
src/modules/fare.js Outdated Show resolved Hide resolved
@ybmin ybmin requested a review from chlehdwon July 23, 2024 13:13
@kmc7468 kmc7468 merged commit 147fc5c into dev Jul 24, 2024
1 check passed
@kmc7468 kmc7468 deleted the #450-택시비용-보여주기 branch July 24, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMHW xMHW xMHW left review comments

@kmc7468 kmc7468 kmc7468 approved these changes

@chlehdwon chlehdwon Awaiting requested review from chlehdwon

Assignees

@ybmin ybmin

Labels
⚒ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

택시 예상 비용
4 participants
@ybmin @kmc7468 @xMHW @chlehdwon