Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#514 랜덤 이메일 업데이트 #515

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

happycastle114
Copy link
Contributor

Summary

It closes #514

@happycastle114 happycastle114 added the 😱 bug Something isn't working label May 7, 2024
@happycastle114 happycastle114 self-assigned this May 7, 2024
@happycastle114 happycastle114 linked an issue May 7, 2024 that may be closed by this pull request
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 로깅 관련된 요청사항 하나만 반영 부탁드려요~~

await userModel.updateOne({ id: userData.id }, updateInfo);
logger.info(`Update user info: ${userData.id}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 값이랑 새로운 값이 모두 로그에 남으면 좋겠습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 네네 알겠습니다!

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmc7468 kmc7468 merged commit ca94c72 into dev May 21, 2024
1 check passed
@kmc7468 kmc7468 deleted the 514-랜덤-이메일-업데이트 branch May 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

랜덤 이메일 업데이트
2 participants