OID4VCI Integration #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbihel
reviewed
Aug 23, 2024
There was a problem hiding this comment.
The CI is failing because of async (which I've fixed in #25)
There's more code than I was expecting but it all looks good. Maybe in the future we'll realise it doesn't need to be too flexible.
I won't approve until the CI is passing and it's all tested end-to-end
Ryanmtate
reviewed
Aug 26, 2024
cobward
reviewed
Aug 27, 2024
|
|
||
| #[uniffi::export] | ||
| pub async fn oid4vci_initiate_with_offer( | ||
| credential_offer: String, |
There was a problem hiding this comment.
What's the format of this string? The code implies that it's JSON, but a credential offer is parsed from a URI. Could we just pass the URI here instead?
theosirian
force-pushed
the
skit-457-integrate-oid4vci-into-sprucekit
branch
2 times, most recently
from
4da58d6 to
d22a9c1
Compare
|
After syncing with @theosirian, we're going to try to merge this as-is before rebasing on the open draft PRs. We'll upstream the changes for the Would it be okay to get this final review today for merge? |
sbihel
approved these changes
Aug 30, 2024
theosirian
force-pushed
the
skit-457-integrate-oid4vci-into-sprucekit
branch
from
ead50a5 to
113b59d
Compare
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
…pper object export; Add async http client trait Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
… interface Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
theosirian
force-pushed
the
skit-457-integrate-oid4vci-into-sprucekit
branch
from
5a6d0f0 to
a93d62e
Compare
Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on spruceid/oid4vci-rs#18.
Bindings compilation status: