Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushed authorization changes #12

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Pushed authorization changes #12

merged 6 commits into from
Dec 21, 2023

Conversation

Juliano1612
Copy link
Member

This adds support to RFC 9126.

@Juliano1612 Juliano1612 requested a review from sbihel December 12, 2023 17:26
cobward
cobward reviewed Dec 13, 2023
View reviewed changes
src/metadata.rs Outdated Show resolved Hide resolved
src/metadata.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
@Juliano1612 Juliano1612 requested a review from cobward December 13, 2023 19:24
sbihel
sbihel requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to have a second pass after having a look at the specs, but this is a good start

Cargo.toml Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
@Juliano1612 Juliano1612 requested a review from sbihel December 18, 2023 20:11
sbihel
sbihel requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
@Juliano1612 Juliano1612 requested a review from sbihel December 19, 2023 19:22
cobward
cobward reviewed Dec 20, 2023
View reviewed changes
src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
src/pushed_authorization.rs Outdated Show resolved Hide resolved
@Juliano1612 Juliano1612 requested a review from cobward December 21, 2023 12:06
@Juliano1612 Juliano1612 merged commit 12e8999 into main Dec 21, 2023
1 check passed
@sbihel sbihel deleted the cred-19-add-pushed-authorization-request-support branch December 21, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cobward cobward cobward approved these changes

@sbihel sbihel sbihel approved these changes

@franklovefrank franklovefrank Awaiting requested review from franklovefrank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juliano1612 @sbihel @cobward