Support localhost:port notation for tests (#723)

staabm · Nov 27, 2024 · a128a1c · a128a1c
1 parent a2d990f
commit a128a1c
Show file tree

Hide file tree

Showing 5 changed files with 68 additions and 60 deletions.
diff --git a/.phpstan-dba-mysqli.cache b/.phpstan-dba-mysqli.cache
diff --git a/.phpstan-dba-pdo-mysql.cache b/.phpstan-dba-pdo-mysql.cache
diff --git a/tests/ReflectorFactory.php b/tests/ReflectorFactory.php
@@ -43,7 +43,7 @@ public static function create(string $cacheDir): QueryReflector
             $ssl = (string) (getenv('DBA_SSL') ?: $_ENV['DBA_SSL'] ?? '');
             $mode = getenv('DBA_MODE') ?: $_ENV['DBA_MODE'];
             $reflector = getenv('DBA_REFLECTOR') ?: $_ENV['DBA_REFLECTOR'];
-            $platform = getenv('DBA_PLATFORM') ?: $_ENV['DBA_PLATFORM'];
+            $platform = getenv('DBA_PLATFORM') ?: $_ENV['DBA_PLATFORM'] ?? '';
         }
 
         // make env vars available to tests, in case non are defined yet
@@ -74,12 +74,18 @@ public static function create(string $cacheDir): QueryReflector
         if (self::MODE_RECORDING === $mode || self::MODE_REPLAY_AND_RECORDING === $mode) {
             $schemaHasher = null;
 
+            $port = null;
+            if (str_contains($host, ':')) {
+                [$host, $port] = explode(':', $host, 2);
+                $port = (int) $port;
+            }
+
             if ('mysqli' === $reflector) {
                 $mysqli = mysqli_init();
                 if (! $mysqli) {
                     throw new \RuntimeException('Unable to init mysqli');
                 }
-                $mysqli->real_connect($host, $user, $password, $dbname, null, null, $ssl ? MYSQLI_CLIENT_SSL : 0);
+                $mysqli->real_connect($host, $user, $password, $dbname, $port, null, $ssl ? MYSQLI_CLIENT_SSL : 0);
                 $reflector = new MysqliQueryReflector($mysqli);
                 $schemaHasher = new SchemaHasherMysql($mysqli);
             } elseif ('pdo-mysql' === $reflector) {
@@ -88,11 +94,13 @@ public static function create(string $cacheDir): QueryReflector
                     $options[PDO::MYSQL_ATTR_SSL_CA] = $ssl;
                     $options[PDO::MYSQL_ATTR_SSL_VERIFY_SERVER_CERT] = false;
                 }
-                $pdo = new PDO(sprintf('mysql:dbname=%s;host=%s', $dbname, $host), $user, $password, $options);
+                $port = $port !== null ? ';port=' . $port : '';
+                $pdo = new PDO(sprintf('mysql:dbname=%s;host=%s', $dbname, $host) . $port, $user, $password, $options);
                 $reflector = new PdoMysqlQueryReflector($pdo);
                 $schemaHasher = new SchemaHasherMysql($pdo);
             } elseif ('pdo-pgsql' === $reflector) {
-                $pdo = new PDO(sprintf('pgsql:dbname=%s;host=%s', $dbname, $host), $user, $password);
+                $port = $port !== null ? ';port=' . $port : '';
+                $pdo = new PDO(sprintf('pgsql:dbname=%s;host=%s', $dbname, $host) . $port, $user, $password);
                 $reflector = new PdoPgSqlQueryReflector($pdo);
             } else {
                 throw new \RuntimeException('Unknown reflector: ' . $reflector);

diff --git a/tests/sqlAst/config/.phpunit-phpstan-dba-mysqli.cache b/tests/sqlAst/config/.phpunit-phpstan-dba-mysqli.cache