Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 🙂
I encountered an edge case with the Regex currently used to parse placeholders.
ℹ️
"
are needed here to escape the-
special character in the field's nameThe problem with the current
(["\'])([^"\']*\1)
regex is that it tries to exclude'
AND"
in the middle of a string. If this is a simply quoted string we should exclude only simple quotes.I found a way to negate a backreference in stackoverflow.
Unfortunately, I totally failed to run tests locally, so I didn't add corresponding test... but I would love to if you have some helping instructions[Edit] it seems that locally I got the same errors encountered by the CI, so maybe the issue is not related to my local setup but tomaster
branch...[Edit 2 ] tests added 🎉
Thanks for you work 🙏