Skip to content

Conversation

AlbertoCasasOrtiz
Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz commented May 20, 2025

Merge with stanfordnmbl/opencap-viewer#436, as they depend on each other.

Copy link
Contributor

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(cross posting this with the viewer PR) Search functionality worked, but a few issues to address:

  • [viewer] The search box just says "Enter text", so users don't know that it's searching Session ID or Session Name
  • [viewer] Once a search is done, I could only get back to the list of sessions by refreshing the page
  • [viewer] Maybe could be nice if the "Submit" button wasn't as large as the other buttons? Might need to play around with this to figure out what looks good.
  • [api] When trying to test the new button delays when recording, the New Session page gave a blank QR code. I could get past this when I merged main into the local branch, but for some reason the cameras could not connect to the session. I did notice that it looks like dev branch is a little behind main branch here, and the api was calling the dev DB, so maybe there was a mismatch there? I haven't dug in further.

@AlbertoCasasOrtiz
Copy link
Collaborator Author

AlbertoCasasOrtiz commented Aug 12, 2025

WIP:

  • [api] When trying to test the new button delays when recording, the New Session page gave a blank QR code. I could get past this when I merged main into the local branch, but for some reason the cameras could not connect to the session. I did notice that it looks like dev branch is a little behind main branch here, and the api was calling the dev DB, so maybe there was a mismatch there? I haven't dug in further.

The problem with the QR and camera connection is an old one, it's been happening for a while, that is why we mostly test on deployed versions on dev when we have to do a full capture testing.

It could be good knowing if someone was able to fix this or if there is any other approach for testing that does not involve having to deploy into dev.

Regarding dev being behind main, I guess that could be problematic in the future. We should update dev with changes in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants