Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cairo): add function at to trace #17

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

noa-starkware
Copy link
Collaborator

@noa-starkware noa-starkware commented Mar 6, 2025

This change is Reviewable

@noa-starkware noa-starkware added the enhancement New feature or request label Mar 6, 2025
@noa-starkware noa-starkware self-assigned this Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@af5da2b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/trace/mock.cairo 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage        ?   88.94%           
=======================================
  Files           ?       34           
  Lines           ?     1664           
  Branches        ?        0           
=======================================
  Hits            ?     1480           
  Misses          ?      184           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noa-starkware noa-starkware removed the enhancement New feature or request label Mar 6, 2025
Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@noa-starkware noa-starkware enabled auto-merge (squash) March 6, 2025 14:27
@noa-starkware noa-starkware merged commit 1e95a10 into main Mar 6, 2025
2 checks passed
@noa-starkware noa-starkware deleted the noa/utils/add-fn-at-to-trace branch March 6, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants