chore(cairo): fix comps comments

[ishay-starkware]

This change is 

[MohammadNassar1]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @uriel-starkware)

---

a discussion (no related file):
Please update spec accordingly.

---

src/components/deposit/deposit.cairo line 23 at r1 (raw file):

    pub struct Storage {
        registered_deposits: Map<HashType, DepositStatus>,
        aggregate_quantized_pending_deposits: Map<felt252, u128>,

Can you please explain why it's okay to remove this map?

Code quote:

aggregate_quantized_pending_deposits: Map<felt252, u128>,

---

src/components/deposit/errors.cairo line 10 at r1 (raw file):

pub const DEPOSIT_NOT_CANCELABLE: felt252 = 'DEPOSIT_NOT_CANCELABLE';
pub const DEPOSIT_NOT_REGISTERED: felt252 = 'DEPOSIT_NOT_REGISTERED';
pub const INVALID_cancel_delay: felt252 = 'INVALID_cancel_delay';

Please use capital letters.

Code quote:

pub const INVALID_cancel_delay: felt252 = 'INVALID_cancel_delay';

[MohammadNassar1]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ishay-starkware and @uriel-starkware)

---

a discussion (no related file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

Please update spec accordingly.

Ooh, the specs are not in this repo, removed.

[ishay-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MohammadNassar1 and @uriel-starkware)

---

src/components/deposit/deposit.cairo line 23 at r1 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

Can you please explain why it's okay to remove this map?

we decided that it's not relevant. no need to keep track of the pending deposits.

---

src/components/deposit/errors.cairo line 10 at r1 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

Please use capital letters.

Done.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0c97ed1). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   87.55%           
=======================================
  Files           ?       38           
  Lines           ?     1318           
  Branches        ?        0           
=======================================
  Hits            ?     1154           
  Misses          ?      164           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MohammadNassar1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ishay-starkware and @uriel-starkware)

---

src/components/deposit/errors.cairo line 10 at r1 (raw file):

Previously, ishay-starkware wrote…

Done.

You didnt push.

[ishay-starkware]

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1 and @uriel-starkware)

---

src/components/deposit/errors.cairo line 10 at r1 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

You didnt push.

pused now

[MohammadNassar1]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)