Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roee gross/remove span utils #33

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Roee gross/remove span utils #33

merged 3 commits into from
Mar 12, 2025

Conversation

RoeeGross
Copy link
Collaborator

@RoeeGross RoeeGross commented Mar 12, 2025

This change is Reviewable

@RoeeGross RoeeGross self-assigned this Mar 12, 2025
@RoeeGross RoeeGross enabled auto-merge (squash) March 12, 2025 11:39
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1a49917). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   87.40%           
=======================================
  Files           ?       36           
  Lines           ?     1302           
  Branches        ?        0           
=======================================
  Hits            ?     1138           
  Misses          ?      164           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware and @uriel-starkware)

@RoeeGross RoeeGross merged commit 5a1ae79 into main Mar 12, 2025
1 of 2 checks passed
@RoeeGross RoeeGross deleted the RoeeGross/remove-span-utils branch March 12, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants