Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fraction): make non generic #34

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

RoeeGross
Copy link
Collaborator

@RoeeGross RoeeGross commented Mar 12, 2025

This change is Reviewable

Copy link
Collaborator

@uriel-starkware uriel-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ishay-starkware)

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@5a1ae79). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/math/fraction.cairo 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   87.35%           
=======================================
  Files           ?       36           
  Lines           ?     1289           
  Branches        ?        0           
=======================================
  Hits            ?     1126           
  Misses          ?      163           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoeeGross RoeeGross removed the request for review from ishay-starkware March 12, 2025 13:32
@RoeeGross RoeeGross merged commit cb180ac into main Mar 12, 2025
4 checks passed
@RoeeGross RoeeGross deleted the RoeeGross/make-fraction-non-generic branch March 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants