Skip to content

Portal Client: Improve node status log #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bhartnett
Copy link
Contributor

@bhartnett bhartnett commented May 24, 2025

I noticed that in the Nimbus Portal fleet logs the Portal node status looks like this for the 2GB nodes:

INF 2025-05-24 14:34:21.128+00:00 Portal node status                         radiusPercentage=0% radius=4beec975f622c1fd982e0cbef253deb9762ad0e437106ab1ca5f1b5a268139 dbSize=2000236kb

And like this for the 35G nodes:

INF 2025-05-24 14:34:20.341+00:00 Portal node status                         radiusPercentage=1% radius=383355a2cc74296f8485be9e5e43df32638ec2db05c9cd99a365bb2384cdc93 dbSize=35000209kb

Using the default storage size of 2G the radiusPercentage shows as 0%. This isn't very useful information for the user and the radius is actually likely to get smaller as the amount of data in the network grows.

To improve the logs I suggest we use log radius and log radius percent which will be a better way to represent the information. We could either show both the radiusPercentage and logRadiusPercentage or just show the log radius named as radiusPercentage (log base 2).

Also now showing the storage in MB instead of KB.

The updated log looks like this:

INF 2025-05-24 22:30:51.773+08:00 Portal node status                         dbSize=0MB logRadiusPercentage=50% logRadius=128 radiusPercentage=0% radius=ffffffffffffffffffffffffffffffff

Alternatively we could show something like:

INF 2025-05-24 22:30:51.773+08:00 Portal node status                         dbSize=0MB logRadius=128/256 radiusPercentage=0% radius=ffffffffffffffffffffffffffffffff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant