-
Notifications
You must be signed in to change notification settings - Fork 31
Improvements to NEMO offloading scripts #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sergisiso
wants to merge
28
commits into
master
Choose a base branch
from
remove_nemo_exlcusions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sergisiso
commented
Jul 9, 2025
- Enables ICE (not not icethd yet), this is used by BENCH and the ORCA2 in ENMASE
- Prevents (if type info is available) characters on offloaded regions
- Converges the NEMOv4 and NEMOv5 produced directives/clauses
- Prevents skipping parallelising loops if they are collapsed anyway
…with_usage_location method
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3047 +/- ##
==========================================
- Coverage 99.92% 99.90% -0.02%
==========================================
Files 365 366 +1
Lines 51716 51766 +50
==========================================
+ Hits 51675 51717 +42
- Misses 41 49 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ormance for NEMOv4
…s (and not offloading much)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.