New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dselans/graceful-exit #24

Merged

dselans merged 2 commits into main from dselans/no-looper

Jun 25, 2024

Contributor

dselans commented Jun 25, 2024 •

edited

Loading

Remove looper to avoid races where Consume is ran in multiple goroutines. Full fix (without removing looper) would mean to create a map of loopers per Consume() but that's a decent chunk of work.
Update Stop() to wait for Consume()'s to exit (using a waitgroup) + optional timeout

dselans added 2 commits

June 25, 2024 14:22


          removing looper to sidestep shutdown complexity

87d4430


          updated Stop() to include optional timeout

311de4b

dselans changed the title ~~Dselans/no looper~~ Dselans/graceful-exit

dselans merged commit db1dcea into main

1 check passed

dselans deleted the dselans/no-looper branch

June 25, 2024 22:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet