Error when having multiple line charts #71 #66 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error when having multiple line charts with ON and OFF Regression I found a problem when adding more then one series to the regression library, I need to have all ON to have regression and cannot be selective regarding which one I would like to have a regression line. I made a few changes to prevent adding undefined series in the case of regression being OFF and when the last series was undefined the validation seemed to not address this issue, so, I changed it as well (concat). With this I can now have a mix of series with regression ON and OFF without any problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error when having multiple line charts with ON and OFF Regression
I found a problem when adding more then one series to the regression library, I need to have all ON to have regression and cannot be selective regarding which one I would like to have a regression line.
I made a few changes to prevent adding undefined series in the case of regression being OFF and when the last series was undefined the validation seemed to not address this issue, so, I changed it as well (concat). With this I can now have a mix of series with regression ON and OFF without any problem.
check issue
#71