Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Remove CardParams form CardWidget #10440

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Mar 20, 2025

Summary

Remove legacy CardParams form CardWidget.
We cannot merge until next major release.

Motivation

JIRA

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   4.1 MiB │   4.1 MiB │ -1.2 KiB │  9.1 MiB │    9 MiB │ -3.1 KiB 
     arsc │   2.4 MiB │   2.4 MiB │      0 B │  2.4 MiB │  2.4 MiB │      0 B 
 manifest │   5.2 KiB │   5.2 KiB │      0 B │ 25.7 KiB │ 25.7 KiB │      0 B 
      res │ 909.3 KiB │ 909.3 KiB │      0 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │     +5 B │  1.6 MiB │  1.6 MiB │     +5 B 
    other │   1.4 MiB │   1.4 MiB │     +3 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │    13 MiB │    13 MiB │ -1.2 KiB │ 22.2 MiB │ 22.2 MiB │ -3.1 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 42873 │ 42862 │ -11 (+53 -64)     
   types │ 15379 │ 15375 │  -4 (+52 -56)     
 classes │ 12981 │ 12979 │  -2 (+4 -6)       
 methods │ 62828 │ 62812 │ -16 (+1294 -1310) 
  fields │ 41878 │ 41863 │ -15 (+1245 -1260) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6275 │ 6275 │  0
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.1 MiB │ -1.2 KiB │     9 MiB │ -3.1 KiB │ ∆ classes.dex                             
  8.1 KiB │     +9 B │     8 KiB │     +9 B │ ∆ assets/dexopt/baseline.prof             
 50.6 KiB │     +7 B │ 119.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
    1 KiB │     -4 B │     902 B │     -4 B │ ∆ assets/dexopt/baseline.profm            
  1.2 KiB │     -4 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    270 B │     -2 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
   54 KiB │     +2 B │   120 KiB │      0 B │ ∆ META-INF/CERT.SF                        
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.2 MiB │ -1.2 KiB │   9.3 MiB │ -3.1 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   42873 │ 42862 │ -11 (+53 -64) 
  
  + Lb6/G;
  + Le3/a;
  + Ls3/i;
  + Lu8/s;
  + [LV6/A;
  + [LV6/C0;
  + [LV6/C1;
  + [LV6/G;
  + [LV6/H0;
  + [LV6/M2;
  + [LV6/M;
  + [LV6/O2;
  + [LV6/P;
  + [LV6/U0;
  + [LV6/W1;
  + [LV6/W;
  + [LV6/Z0;
  + [LV6/b0;
  + [LV6/d3;
  + [LV6/e1;
  + [LV6/e2;
  + [LV6/g0;
  + [LV6/h2;
  + [LV6/i1;
  + [LV6/i3;
  + [LV6/k2;
  + [LV6/l0;
  + [LV6/o0;
  + [LV6/p3;
  + [LV6/q3;
  + [LV6/q;
  + [LV6/r2;
  + [LV6/u0;
  + [LV6/u;
  + [LV6/w1;
  + [LV6/w;
  + [LV6/z0;
  + [LW2/q;
  + [Landroidx/recyclerview/widget/C0;
  + [Lb6/B;
  + [Lb6/d;
  + [Lb6/z;
  + [Lcom/google/android/material/datepicker/n;
  + [Lf6/D2;
  + [Lf6/J2;
  + [Lf6/W;
  + [Lf6/Z;
  + [Ll6/D;
  + [Lo6/p;
  + [Ls9/n0;
  + [Lu8/s;
  + [Lz8/a;
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"aa1df91","r8-mode":"full","version":"8.8.27"}
  
  - , expMonth=
  - , loggingTokens=
  - CardParams(brand=
  - LV6/w3;
  - LV6/x3;
  - Landroidx/recyclerview/widget/G0;
  - Lcom/google/android/material/datepicker/z;
  - Lq3/d;
  - Ls9/q0;
  - Networks(preferred=
  - VLLLIILLLLLL
  - [LV6/A0;
  - [LV6/A1;
  - [LV6/C;
  - [LV6/G0;
  - [LV6/K;
  - [LV6/L2;
  - [LV6/N2;
  - [LV6/N;
  - [LV6/S0;
  - [LV6/S;
  - [LV6/U1;
  - [LV6/X0;
  - [LV6/a0;
  - [LV6/b3;
  - [LV6/c1;
  - [LV6/c2;
  - [LV6/f0;
  - [LV6/f2;
  - [LV6/g1;
  - [LV6/g3;
  - [LV6/i2;
  - [LV6/k0;
  - [LV6/l3;
  - [LV6/m3;
  - [LV6/n0;
  - [LV6/p2;
  - [LV6/p;
  - [LV6/t0;
  - [LV6/t;
  - [LV6/u1;
  - [LV6/v;
  - [LV6/w3;
  - [LV6/x3;
  - [LV6/y0;
  - [LV6/z;
  - [LW2/s;
  - [Landroidx/recyclerview/widget/E0;
  - [Lb6/A;
  - [Lb6/c;
  - [Lb6/y;
  - [Lcom/google/android/material/datepicker/o;
  - [Lf6/E2;
  - [Lf6/K2;
  - [Lf6/X;
  - [Lf6/a0;
  - [Ll6/F;
  - [Lo6/r;
  - [Ls9/o0;
  - [Lu8/q;
  - [Lz8/c;
  - getCardParams
  - loggingTokens
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"b5da890","r8-mode":"full","version":"8.8.27"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   15379 │ 15375 │ -4 (+52 -56) 
  
  + Lb6/G;
  + Le3/a;
  + Ls3/i;
  + Lu8/s;
  + [LV6/A;
  + [LV6/C0;
  + [LV6/C1;
  + [LV6/G;
  + [LV6/H0;
  + [LV6/M2;
  + [LV6/M;
  + [LV6/O2;
  + [LV6/P;
  + [LV6/U0;
  + [LV6/W1;
  + [LV6/W;
  + [LV6/Z0;
  + [LV6/b0;
  + [LV6/d3;
  + [LV6/e1;
  + [LV6/e2;
  + [LV6/g0;
  + [LV6/h2;
  + [LV6/i1;
  + [LV6/i3;
  + [LV6/k2;
  + [LV6/l0;
  + [LV6/o0;
  + [LV6/p3;
  + [LV6/q3;
  + [LV6/q;
  + [LV6/r2;
  + [LV6/u0;
  + [LV6/u;
  + [LV6/w1;
  + [LV6/w;
  + [LV6/z0;
  + [LW2/q;
  + [Landroidx/recyclerview/widget/C0;
  + [Lb6/B;
  + [Lb6/d;
  + [Lb6/z;
  + [Lcom/google/android/material/datepicker/n;
  + [Lf6/D2;
  + [Lf6/J2;
  + [Lf6/W;
  + [Lf6/Z;
  + [Ll6/D;
  + [Lo6/p;
  + [Ls9/n0;
  + [Lu8/s;
  + [Lz8/a;
  
  - LV6/w3;
  - LV6/x3;
  - Landroidx/recyclerview/widget/G0;
  - Lcom/google/android/material/datepicker/z;
  - Lq3/d;
  - Ls9/q0;
  - [LV6/A0;
  - [LV6/A1;
  - [LV6/C;
  - [LV6/G0;
  - [LV6/K;
  - [LV6/L2;
  - [LV6/N2;
  - [LV6/N;
  - [LV6/S0;
  - [LV6/S;
  - [LV6/U1;
  - [LV6/X0;
  - [LV6/a0;
  - [LV6/b3;
  - [LV6/c1;
  - [LV6/c2;
  - [LV6/f0;
  - [LV6/f2;
  - [LV6/g1;
  - [LV6/g3;
  - [LV6/i2;
  - [LV6/k0;
  - [LV6/l3;
  - [LV6/m3;
  - [LV6/n0;
  - [LV6/p2;
  - [LV6/p;
  - [LV6/t0;
  - [LV6/t;
  - [LV6/u1;
  - [LV6/v;
  - [LV6/w3;
  - [LV6/x3;
  - [LV6/y0;
  - [LV6/z;
  - [LW2/s;
  - [Landroidx/recyclerview/widget/E0;
  - [Lb6/A;
  - [Lb6/c;
  - [Lb6/y;
  - [Lcom/google/android/material/datepicker/o;
  - [Lf6/E2;
  - [Lf6/K2;
  - [Lf6/X;
  - [Lf6/a0;
  - [Ll6/F;
  - [Lo6/r;
  - [Ls9/o0;
  - [Lu8/q;
  - [Lz8/c;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   62828 │ 62812 │ -16 (+1294 -1310) 
  
  + A7.K1 y(m3, k, boolean)
  + A7.L1 <init>(l1)
  + A7.M1 <init>(r1)
  + A7.N1 <init>(y1)
  + A7.N b() → Q1
  + A7.N d() → U1
  + A7.O b() → Q1
  + A7.O d() → U1
  + A7.P b() → Q1
  + A7.P d() → U1
  + A7.a a(B1, boolean, Continuation) → Object
  + A7.e2 <init>(n2, B1, b, Function1, Continuation)
  + A7.l2 <init>(n2, B1, Continuation)
  + A7.l a(c, B1, boolean, boolean) → w
  + A7.l c(c, B1, boolean, int) → w
  + A7.n2 a(B1, i, Function1, ContinuationImpl) → Object
  + A7.n2 b(B1, ContinuationImpl) → Serializable
  + A7.n2 d(B1, Continuation) → Object
  + A7.w <init>(c, B1, P1, boolean, boolean)
  + A7.x a(String, h1)
 
...✂

@toluo-stripe toluo-stripe changed the title Remove CardParams form CardInputWidget Remove CardParams form Card*Widget Mar 20, 2025
@toluo-stripe toluo-stripe force-pushed the tolu/remediation/remove_card_params branch from 9e2e75c to 7e54579 Compare March 20, 2025 05:02
@toluo-stripe toluo-stripe changed the title Remove CardParams form Card*Widget Remove CardParams form CardWidget Mar 20, 2025
@toluo-stripe toluo-stripe marked this pull request as ready for review March 20, 2025 15:00
@toluo-stripe toluo-stripe requested review from a team as code owners March 20, 2025 15:00
@jaynewstrom-stripe jaynewstrom-stripe changed the title Remove CardParams form CardWidget [DO NOT MERGE] Remove CardParams form CardWidget Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants